-
Notifications
You must be signed in to change notification settings - Fork 123
Add experimental OpAMP client #4486
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
# Conflicts: # src/OpenTelemetry.AutoInstrumentation/Configurations/GeneralSettings.cs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have 2 concerns here
- New transitive dependencies.
Google.Protobufwas already removed from the distribution in scope of update od OTel ADK to 1.11.0: 3986System.Collections.Immutable- Do you any possibility to drop this dependency in Opam.Client package?
- Lack of integration tests with OpAmp server. I see 2 options here
- create mocked server as we have for OTLP protocol
- Utilize some existing dockerized server.
Adding this kind of tests can be done as follow up PR.
I was looking what OpenTelemetry.Exporter.OpenTelemetryProtocol was doing. This experience could be transferred to OpAMP client as well.
Probably not. This may have to stay.
I could reuse OpAMP Go's example server. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe it makes sense to create separate settings for OpAMP and handle calculations there (ConnectionType and ServerUrl). This would allow us :
- Keep code consistency
- Add file-based configuration
Yes, this seems good change for this PR even. |
|
Moving to draft. The plan is to implement the next version without deps. |
What
Adds experimental opamp client.
More info in contrib repo:
https://github.com/open-telemetry/opentelemetry-dotnet-contrib/tree/main/src/OpenTelemetry.OpAmp.Client
Tests
Build was locally tested.
Additional tools are unit tested.
Checklist
CHANGELOG.mdis updated.